Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator Config API #20

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Operator Config API #20

merged 1 commit into from
Jun 26, 2024

Conversation

nb-ohad
Copy link
Collaborator

@nb-ohad nb-ohad commented Jun 23, 2024

Describe what this PR does

Adds new API named OperatorConfig (operatorconfigs.csi.ceph.io) to capture operator-level configuration including overwrites for driver spec default configuration

The PR does not include CRD field validation rules.
This will be resolved in a future PR

Is there anything that requires special attention

No

Related issues

Future concerns

There is still an active discussion around API naming and at the time of this PR we are still open to future name changes

@nb-ohad nb-ohad requested a review from Madhu-1 June 23, 2024 12:25
@nb-ohad nb-ohad force-pushed the op-config-api branch 7 times, most recently from e29d24f to 841a767 Compare June 26, 2024 10:46
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, can you please typo's

@nb-ohad
Copy link
Collaborator Author

nb-ohad commented Jun 26, 2024

@Madhu-1 done

API generated using the following command:
"kubebuilder create api --group csi --version v1alpha1 --kind OperatorConfig"

Signed-off-by: nb-ohad <[email protected]>
@Madhu-1 Madhu-1 merged commit cbda8db into ceph:main Jun 26, 2024
4 checks passed
parth-gr pushed a commit to parth-gr/ceph-csi-operator that referenced this pull request Aug 26, 2024
…k-17-to-release-4.17

BUG 2304810: [release-4.17] add owners to downstream repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants